Support for close code 1012-1014 #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted test Added close codes Fixes TooTallNate#639
7.9.6 checks against close code 1014. Since 1014 is registred, it is now a valid close code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for close codes 1012-1014
See https://www.iana.org/assignments/websocket/websocket.xml#close-code-number for reference
Removed autobahn test result check for test 7.9.6 since this testcase will now always fail!
Related Issue
Fixes #639
Motivation and Context
Additions to the specification
How Has This Been Tested?
Adjusted CloseFrame test
Adjusted Autobahn test result check
Types of changes
Checklist: