Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Connecting and additional tests #682

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Deprecate Connecting and additional tests #682

merged 2 commits into from
Mar 20, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Mar 20, 2018 •
edited
Loading

Description

Deprecate Connecting and additional tests

Related Issue

Fixes #681

Motivation and Context

Improve code quality

How Has This Been Tested?

No tests needed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.3.9 milestone Mar 20, 2018
@marci4 marci4 added this to To do in Development via automation Mar 20, 2018
@marci4 marci4 merged commit c08be4e into TooTallNate:master Mar 20, 2018
Development automation moved this from To do to Done Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor
Projects
No open projects
Development
  
Done
Milestone
Release 1.3.9
Development

Successfully merging this pull request may close these issues.

READYSTATE.CONNECTING not use
1 participant
@marci4