Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebSocketClient.java #683

Merged
merged 2 commits into from
Mar 30, 2018
Merged

Update WebSocketClient.java #683

merged 2 commits into from
Mar 30, 2018

Conversation

xcelder
Copy link
Contributor

@xcelder xcelder commented Mar 23, 2018

Added check for wss default port to avoid including it into the host. Some servers with proxy balancers may missunderstand the url if it includes the default port.

Description

Related Issue

Fixes #685

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Added check for wss default port to avoid including it into the host. Some servers with proxy balancers may missunderstand the url if it includes the default port.
@marci4
Copy link
Collaborator

marci4 commented Mar 23, 2018

Hello @xcelder,

Could you please open an issue for this to discuss the problem, the steps to reproduce and the resulting fix for this ?

Thank you!

Greetings
Marci4

@marci4
Copy link
Collaborator

marci4 commented Mar 26, 2018

Please create an issue or I will close this PR as cannot reproduce!

@xcelder
Copy link
Contributor Author

xcelder commented Mar 27, 2018

Sorry, i create an issue

@marci4 marci4 self-assigned this Mar 30, 2018
Copy link
Collaborator

@marci4 marci4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change WbSocket.DEFAULT_WSS_PORT to WebSocket.DEFAULT_WSS_PORT (quess you just had a typo). Thank you!

@marci4 marci4 merged commit ed73b32 into TooTallNate:master Mar 30, 2018
@marci4 marci4 added this to the Release 1.3.9 milestone Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude default port from wss host
2 participants