Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed assertion from WebSocketImpl.isOpen (see #694) #702

Merged
merged 1 commit into from
Apr 29, 2018
Merged

Removed assertion from WebSocketImpl.isOpen (see #694) #702

merged 1 commit into from
Apr 29, 2018

Conversation

PhilipRoman
Copy link
Collaborator

Removed assertion from WebSocketImpl.isOpen()

Related Issue

Issue #694

Motivation and Context

There are some situations where the assertion may be triggered from normal usage.
A getter method such as this should not throw an exception.

How Has This Been Tested?

The project builds correctly and examples run. I have not run the autobahn test suite.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I doubt any of the following should apply in this case:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 self-requested a review April 29, 2018 16:25
@marci4 marci4 merged commit af0ed60 into TooTallNate:master Apr 29, 2018
@marci4
Copy link
Collaborator

marci4 commented Apr 29, 2018

Hallo @PhilipRoman,

thank you very much for your PR and your contribution to this project!

Best regards,
marci4

@marci4 marci4 added this to the Release 1.3.9 milestone Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants