Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a timeout option for connectBlocking #724

Merged
merged 2 commits into from
Jun 27, 2018

Conversation

cymp
Copy link
Contributor

@cymp cymp commented Jun 26, 2018

No description provided.

Copy link
Collaborator

@PhilipRoman PhilipRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! I noticed the indentation doesn't match the rest of the code (2 spaces vs 1 tab). Maybe it should be converted for sake of clean diffs when someone decides to autoformat?

@cymp
Copy link
Contributor Author

cymp commented Jun 26, 2018

Well I couldn't find a code style settings for this project Which one should I use for IntelliJ?

@PhilipRoman
Copy link
Collaborator

CodeFormatterProfile.xml at project root

@cymp
Copy link
Contributor Author

cymp commented Jun 26, 2018

Wow sorry...

@cymp
Copy link
Contributor Author

cymp commented Jun 26, 2018

I tried to import this eclipse profile in IntelliJ, but it is not perfect (it automatically put the @OverRide annotation left to method declaration for example), so I had to add the tabs myself.

@PhilipRoman
Copy link
Collaborator

Tested it, everything works as expected.

@PhilipRoman PhilipRoman merged commit 41b2872 into TooTallNate:master Jun 27, 2018
@cymp
Copy link
Contributor Author

cymp commented Jun 27, 2018

@PhilipRoman
Are there any snapshot release, how am I supposed to be able to download via maven what I just did ?

@PhilipRoman
Copy link
Collaborator

Not sure what's the best way for this project (I don't use maven for dep management) but as a quick fix, you can always git clone, then mvn package and add the jar as a local library to your project (until next release).

@marci4
Copy link
Collaborator

marci4 commented Jun 27, 2018

@PhilipRoman, gratz on your first merged PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants