-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a timeout option for connectBlocking #724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! I noticed the indentation doesn't match the rest of the code (2 spaces vs 1 tab). Maybe it should be converted for sake of clean diffs when someone decides to autoformat?
Well I couldn't find a code style settings for this project Which one should I use for IntelliJ? |
CodeFormatterProfile.xml at project root |
Wow sorry... |
I tried to import this eclipse profile in IntelliJ, but it is not perfect (it automatically put the @OverRide annotation left to method declaration for example), so I had to add the tabs myself. |
Tested it, everything works as expected. |
@PhilipRoman |
Not sure what's the best way for this project (I don't use maven for dep management) but as a quick fix, you can always |
@PhilipRoman, gratz on your first merged PR! :) |
No description provided.