Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when using reconnect in websocket thread #739

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Jul 17, 2018

Description

Throw an exception if you are using reconnect in a websocket thread

Related Issue

Fixes #732

Motivation and Context

No blocking + info

How Has This Been Tested?

Added tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

throw an exception if reconnect is called out of the connectRead or
write thread
@marci4 marci4 added this to the Release 1.3.9 milestone Jul 17, 2018
@marci4 marci4 merged commit 9918a55 into TooTallNate:master Jul 17, 2018
@marci4 marci4 deleted the Reconnect branch July 17, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reconnect() method will block
1 participant