Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated build instructions from README #821

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Remove outdated build instructions from README #821

merged 1 commit into from
Dec 6, 2018

Conversation

PhilipRoman
Copy link
Collaborator

Description

Building with ant is no longer supported (de70cdc) but README still contains instructions on how to build with ant

Related Issue

#819

Motivation and Context

Hopefully obvious

How Has This Been Tested?

Looks fine to me

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PhilipRoman
Remove outdated build instructions from README
fca3512 
Building with ant is no longer supported (see #819 )
@marci4
Copy link
Collaborator

marci4 commented Nov 29, 2018

I planned to update it with #755 together, thanks for doing it!

@marci4 marci4 self-requested a review November 29, 2018 12:10
marci4
marci4 approved these changes Nov 29, 2018
View reviewed changes
Copy link
Collaborator

@marci4 marci4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@marci4 marci4 merged commit 566da02 into master Dec 6, 2018
@marci4 marci4 added this to the Release 1.4.0 milestone Dec 6, 2018
@marci4 marci4 mentioned this pull request Dec 6, 2018
Closed
@marci4 marci4 added the Build label Dec 6, 2018
@marci4 marci4 deleted the PhilipRoman-update-readme branch December 6, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marci4 marci4 marci4 approved these changes

Assignees
No one assigned
Labels
Build Documentation Refactor
Projects
None yet
Milestone
Release 1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhilipRoman @marci4