This repository has been archived by the owner on May 5, 2023. It is now read-only.
skip https.request patching if already done #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfernandestoptal
force-pushed
the
fix-https-request-patch-leak
branch
from
9c295a5
to
f2aaaa3
Compare
vfernandestoptal
changed the title
|
This issue impacts many downstream libraries. Please consider accepting this PR. |
2 tasks
This was referenced Jun 5, 2019
TooTallNate
pushed a commit
to TooTallNate/node-http-proxy-agent
that referenced
this pull request
Jun 5, 2019
TooTallNate
pushed a commit
to TooTallNate/proxy-agents
that referenced
this pull request
Jun 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into the same issue as described in #22 when using PubNub JavaScript SDK, which includes this via
superagent-proxy.This fix prevents re-patching
httpsmethod for each test executed byjestby checking for a marker to flag that the patch is already done.fixes #22