make node-speaker node10x compatible, use internal stream node module #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually no deadly necessary pull request. This mainly fixes bunch of deprecation warnings from Nan. I was in an attempt to fix a problem with new thread-workers in Node10 so I made these changes. But then found out that it wasn't the root of my problem nodejs/node#21481 otherwise the tests run, produces expected audio on my computer, all deps are bumped, with the readable dep removed in favor of the internal stream module provided by nodejs ecosystem. The old readable-stream module is mostly a polyfill for browser compatability as far as I understood it, bumping it to v3x caused errors with node-speaker.