Node.js 12 support #133
Closed
Node.js 12 support #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate deprecated V8 APIs and update nan dependency.
Add an editors section to the .gitignore file and list the '.vscode' folder.
|
The PR #120 seems to address the deprecation warnings. |
|
This PR doesn't seem to have been addressed for a couple of months. Would it be okay to friendly-fork this project with these changes? |
ShenHongFei
approved these changes
Aug 18, 2019
|
Any chance we can get a canary / beta / rc build of this published to npm? EDIT: I published a build myself. https://npm.im/@cspotcode/speaker I just pulled the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate V8 API calls and update vulnerable dependencies using
npm audit.For reference: Some of the API changes are described here.