Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prebuilds #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add prebuilds #141

wants to merge 1 commit into from

Conversation

dy
Copy link
Contributor

@dy dy commented Jan 1, 2020

This adds simple prebuilds as per prebuildify readme.
Fixes #76
@TooTallNate @LinusU is maintaining prebuilds of any interest or better left for a separate repository?

@dy
Copy link
Contributor Author

dy commented Sep 21, 2021

Maybe one day this will fall off by itself.

@LinusU
Copy link
Collaborator

LinusU commented Sep 22, 2021

Hmm, should the binaries really be committed to Git? How about generating them in the prepare or prepublishOnly script?

This only seems to be for windows? Seems like we need to pass the --platform flag in order to generate for all our supported platforms?

Should we also pass the --strip flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prebuilds
2 participants