Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select audio device #91

Closed
wants to merge 1 commit into from

Conversation

meldron
Copy link

@meldron meldron commented Oct 7, 2016

Patch to allow the selection of the audio device via opts.device, which is then passed to mpeg123 (as ao->device).

@Flowr-es
Copy link

Flowr-es commented Mar 14, 2017

I would like to see this in, the code looks fine for me but I'm no contributor.
Also looking to the automated builds, acutally only on node 2 and 3 it is failing, I think this is not related to your changes.

Update: I have tested it on my Raspberry (Linux) and it seems not to work, I have given the device name that was given from aplay -L but there is no output on this device (on my default is currently no speaker, so I cannot say if it is no audio output or still on default device)

@meldron
Copy link
Author

meldron commented Apr 5, 2017

Hey @Mexxxo,

can you tell me whats the problem with the output?

Did you check the number of channels our device supports?

@LinusU
Copy link
Collaborator

LinusU commented Apr 8, 2017

Hey @meldron,

Sorry for the huge delay on this, would you mind including some documentation for this in the readme?

Thanks :)

@Flowr-es
Copy link

@meldron once I will get my hands on this again, I will try to provide more infromation.
My output device should handle both, single and stereo channel.

@Flowr-es
Copy link

Hey @meldron, sorry I have simply set my usb audio device to default via alsa, so I discontinued testing.
I'm sure that I did something wrong and your implementation should be fine

@T-vK
Copy link

T-vK commented Sep 5, 2017

@meldron @LinusU I'm very interested in seeing this being merged.
I assume the device parameter is equal to what you would pass to ALSA? i.e. hw:0,0 or plughw:CARD=0,DEV=0? In that case, I wouldn't mind adding that to the readme.

@T-vK
Copy link

T-vK commented Sep 5, 2017

I just want to confirm my assumption about the device parameter. I have tested it and it works without a problem. (That is on Linux with ALSA.)

For the readme, this is what I could provide:

  • device - The name of the playback device. E.g. 'hw:0,0' (first device of first sound card) 'hw:1,0' (first device of second sound card. Defaults to undefined (which means the backend's default device will be chosen).
    only tested with ALSA as the backend

@meldron
Copy link
Author

meldron commented Mar 29, 2018

Hey guys and @LinusU , so I guess i totally forgot to add the docs. Still interessted? I would apply the patch to the lastest version in master or are you going to switch to libao soon?

@T-vK
Copy link

T-vK commented Mar 29, 2018

As far as I'm concerned, yes, i'm still interested.

@LinusU
Copy link
Collaborator

LinusU commented Mar 29, 2018

Just merged #105 and released as version 0.4.1

device support is now live 🚀 thanks a ton to everyone who helped out with this!

@LinusU LinusU closed this Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants