index: emit an "error" event when data is written with no parsing fun…

…ction is in place
TooTallNate · Jun 18, 2014 · 24c2565 · 24c2565
1 parent a8ee41c
commit 24c2565
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -158,7 +158,9 @@ function transform (chunk, output, fn) {
  */
 
 function _data (stream, chunk, output, fn) {
-  assert(stream._parserBytesLeft > 0, 'got data but not currently parsing anything');
+  if (stream._parserBytesLeft <= 0) {
+    return fn(new Error('got data but not currently parsing anything'));
+  }
 
   if (chunk.length <= stream._parserBytesLeft) {
     // small buffer fits within the "_parserBytesLeft" window

diff --git a/test/writable.js b/test/writable.js
@@ -143,6 +143,16 @@ describe('Writable streams', function () {
       w.end(data);
     });
 
+    it('should emit an "error" event when data is written with no parsing function', function (done) {
+      var w = new Writable();
+      Parser(w);
+      w.once('error', function (err) {
+        assert(err);
+        done();
+      });
+      w.write('a');
+    });
+
   });
 
   describe('FrameParser', function () {
@@ -177,7 +187,6 @@ describe('Writable streams', function () {
       p.write(new Buffer([ s.length ]));
       p.write(new Buffer(s));
       p.end();
-
     });
 
     it('should emit 2 "frame" events', function (done) {