Set the proper byte length of the Application#icon

TooTallNate · Jan 13, 2024 · 4bb8a5c · 4bb8a5c
1 parent 8faad62
commit 4bb8a5c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/six-dodos-flash.md b/.changeset/six-dodos-flash.md
@@ -0,0 +1,5 @@
+---
+'nxjs-runtime': patch
+---
+
+Set the proper byte length of the `Application#icon`
diff --git a/source/ns.c b/source/ns.c
@@ -54,7 +54,8 @@ static JSValue nx_ns_application_record(JSContext *ctx, JSValueConst this_val, i
 		return JS_EXCEPTION;
 	}
 	JS_SetPropertyStr(ctx, val, "nacp", JS_NewArrayBufferCopy(ctx, (const uint8_t *)&controlData.nacp, sizeof(controlData.nacp)));
-	JS_SetPropertyStr(ctx, val, "icon", JS_NewArrayBufferCopy(ctx, (const uint8_t *)&controlData.icon, sizeof(controlData.icon)));
+	size_t iconSize = outSize - sizeof(controlData.nacp);
+	JS_SetPropertyStr(ctx, val, "icon", JS_NewArrayBufferCopy(ctx, (const uint8_t *)&controlData.icon, iconSize));
 
 	NacpLanguageEntry *langEntry;
 	rc = nacpGetLanguageEntry(&controlData.nacp, &langEntry);