Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript type definitions #66

merged 2 commits into from May 21, 2019

TypeScript type definitions #66

merged 2 commits into from May 21, 2019


Copy link

This PR is just to bring attention to the missing type definitions. Not everyone uses TypeScript, but for those who do, having this file in this repo would be incredibly helpful.

index.d.ts is based on: #27 (comment) (thank you @yonilerner)

Please let us know if this is ok! Any form of feedback is appreciated.

@TooTallNate TooTallNate merged commit c5c4ffc into TooTallNate:master May 21, 2019
Copy link

Thank you!

Copy link
Collaborator Author

@TooTallNate yayy \o/

Don't we need to upgrade the version now?

@sadasant sadasant deleted the patch-1 branch May 21, 2019 20:05
sadasant added a commit to Azure/azure-sdk-for-js that referenced this pull request May 21, 2019
Once https-proxy-agent type definitions are added,
these changes will be necessary to make this sample work.

The PR that introduces the TypeScript definitions to https-proxy-agent

This commit is related to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants