Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dependency #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mohitpubnub
Copy link

  • upgrade proxy-agent dependency

@mohitpubnub
Copy link
Author

@TooTallNate can we have this dependency upgraded

Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohitpubnub I am not a maintainer on this project, but I predict that they will not want the new files I commented on below included in the proxy-agent dependency bump.

.DS_Store Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@robbkidd
Copy link
Contributor

This PR is related to #48.

@mohitpubnub
Copy link
Author

May be it's a bit clean now!

@robbkidd
Copy link
Contributor

It's clean-er now, certainly. Thanks!

As you can see from #48, getting a release out may be more complicated than just this dependency bump.

@dargmuesli
Copy link

What would make it more complicated than an merge of this PR and a release, @robbkidd?

@robbkidd
Copy link
Contributor

robbkidd commented Aug 2, 2023

@dargmuesli The changes in this PR are insufficient to keep superagent-proxy working with proxy-agent v6, a major version bump. This simple upgrade causes superagent-proxy to fail wiring up a proxy configuration onto superagent clients.

I have attempted to demonstrate that failure in #50, which is a duplicate of this PR's dependency bump that I applied after I fixed the tests and added a CI workflow. The new workflow is not accepted as I write this, so in the meantime you can see the failures in a demonstration on my fork. #50 now has running CI tests and shows to problem and progress toward addressing it.

Hopefully I've added enough test infrastructure for people more knowledgeable than I am about ES modules to work an update for the import.

@TooTallNate
Copy link
Owner

You're gonna have to do const { ProxyAgent } = require('proxy-agent'). There is no longer a default export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants