Skip to content

Commit

Permalink
fix : added tooltips for create and edit row in large fk values
Browse files Browse the repository at this point in the history
  • Loading branch information
S-Abdul-Rahman committed May 22, 2024
1 parent a38024e commit 52e5d59
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ const DropDownSelect = ({
fetchTables,
onTableClick,
referencedForeignKeyDetails = [],
isCreateRow = false,
isEditRow = false,
}) => {
const popoverId = useRef(`dd-select-${uuidv4()}`);
const popoverBtnId = useRef(`dd-select-btn-${uuidv4()}`);
Expand Down Expand Up @@ -182,6 +184,8 @@ const DropDownSelect = ({
actions={actions}
actionName={actionName}
referencedForeignKeyDetails={referencedForeignKeyDetails}
isCreateRow={isCreateRow}
isEditRow={isEditRow}
/>
</Popover>
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ function DataSourceSelect({
actions,
actionName,
referencedForeignKeyDetails,
isCreateRow,
isEditRow,
}) {
const [isLoadingFKDetails, setIsLoadingFKDetails] = useState(false);
const [searchValue, setSearchValue] = useState('');
Expand Down Expand Up @@ -288,7 +290,7 @@ function DataSourceSelect({
message={children}
placement="top"
tooltipClassName="tjdb-cell-tooltip"
show={isCellEdit && children?.length > 30}
show={(isCellEdit || isCreateRow || isEditRow) && children?.length > 30}
>
<span
className={cx({
Expand Down
1 change: 1 addition & 0 deletions frontend/src/TooljetDatabase/Forms/EditRowForm.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ const EditRowForm = ({
setReferencedColumnDetails={setReferencedColumnDetails}
scrollEventForColumnValus={true}
cellColumnName={columnName}
isEditRow={true}
/>
) : (
<input
Expand Down
1 change: 1 addition & 0 deletions frontend/src/TooljetDatabase/Forms/RowForm.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ const RowForm = ({ onCreate, onClose, referencedColumnDetails, setReferencedColu
setReferencedColumnDetails={setReferencedColumnDetails}
scrollEventForColumnValus={true}
cellColumnName={columnName}
isCreateRow={true}
/>
) : (
<input
Expand Down

0 comments on commit 52e5d59

Please sign in to comment.