Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dashboard needs a refresh to get the add folder icon(+) back once the search icon is clicked #8679

Closed
karan-rathod-316 opened this issue Jan 31, 2024 · 21 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs

Comments

@karan-rathod-316
Copy link
Collaborator

What is the expected behaviour?

When you click on the search button and then click somewhere else without typing, the cross button should show to close the search bar.

Screenshot 2024-01-31 at 8 32 25 PM Screenshot 2024-01-31 at 8 32 51 PM

What is the current behaviour?

Once the search icon is clicked and we click somewhere else without typing anything in the search bar, the cross button does not show up. Because of this, the dashboard needs a refresh to get the add folder icon(+) back.

Screenshot 2024-01-31 at 8 33 32 PM

How to reproduce the issue?

  1. Go to the dashboard
  2. Click on the search icon
  3. Click somewhere else without entering any text in the search bar

If the bug is confirmed, would you be willing to submit a PR?

No

@karan-rathod-316 karan-rathod-316 added bug Something isn't working good first issue Good for newcomers up-for-grabs labels Jan 31, 2024
@7pixel-cl
Copy link

Hey, how are you guys? If possible, let me take this one.

@karan-rathod-316
Copy link
Collaborator Author

Hi @7pixel-cl, I am assigning the issue to you. We appreciate your interest in contributing to ToolJet:-).

@iAdtya
Copy link

iAdtya commented Feb 7, 2024

Hii Karan plz reassign the issue to me i have coded the solution but the only problem i am having trouble setting up project locally can i get some guidance on how to solve this error so that i can raise a pr
Screenshot 2024-02-05 200947

@Rohankumarmenu
Copy link

Hello Karan, can you assign this task to me.

@karan-rathod-316
Copy link
Collaborator Author

Hi @7pixel-cl, has there been any progress on this issue??

@karan-rathod-316
Copy link
Collaborator Author

Hi @Rohankumarmenu, I am re-assigning this to you since we haven't received any response from @7pixel-cl.

@HermanBide
Copy link

has this bug been fixed?

@karan-rathod-316
Copy link
Collaborator Author

Hi @HermanBide, this has been assigned to @Rohankumarmenu last week. I can re-assign it to you in case there is no progress by the end of this week. Let me know if you would be interested in picking it up.

@Rohankumarmenu
Copy link

Hello @karan-rathod-316 ,while I am running it on my local system using docker, i am getting error "Database Connection error ".I had gone through and followed the given docker documentation steps for set up. Can you help me with this?

@iAdtya
Copy link

iAdtya commented Feb 22, 2024

@karan-rathod-316 even i got the same error i posted it above, i even tried it cloud postgres database!! but the error persists

@karan-rathod-316
Copy link
Collaborator Author

Hi @adishM98, Can you please check the issue that @Rohankumarmenu is facing?

@Just-A-Pixel
Copy link
Contributor

Is this still being worked on? I'd like to pick this up if no one is working on it.

@karan-rathod-316
Copy link
Collaborator Author

Hi @Just-A-Pixel, @Rohankumarmenu is working on it, and we will give him some more time to resolve the issue :-).

@609harsh
Copy link
Contributor

609harsh commented Mar 4, 2024

Is someone still working on this?

@karan-rathod-316
Copy link
Collaborator Author

Hi @609harsh, assigning this to you. Happy coding :-)

@Rohit-Singh-Rawat
Copy link

Hi @karan-rathod-316, issue resolved. Please review and share feedback. Thanks!

@609harsh
Copy link
Contributor

609harsh commented Mar 7, 2024

Hi @karan-rathod-316 i have resolved the issue. I have created a pull request #9020 , but it seems there is some problem with PR. Since its my first contribution please look into it and guide me for the same

@karan-rathod-316
Copy link
Collaborator Author

@609harsh No worries. We are reviewing your PR.

@Rohit-Singh-Rawat
Copy link

@karan-rathod-316 if possible review mine it would be great if u give some suggestion so that i can learn something new

@karan-rathod-316
Copy link
Collaborator Author

Hi @karan-rathod-316, issue resolved. Please review and share feedback. Thanks!

Hi @Rohit-Singh-Rawat, we are reviewing the original assignee's PR at the moment. It would be great if you can get the issue assigned before working on it:-). In case the original assignee is not able to complete it, I can consider your PR.

@Rohit-Singh-Rawat
Copy link

No problem, and I am sorry, will positively ask for assigning next time. Pls consider if original assignee not able to complete it.
Thanks.

gsmithun4 pushed a commit that referenced this issue Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs
Projects
None yet
Development

No branches or pull requests

8 participants