LTS [Marketplace]: Appwrite patch

[akshaysasidrn]

🛠️ Fixes

• Update Appwrite plugin in #9285 by @blank0537
  • closes: #5775, #4764, #4475
• Update Appwrite plugin version from 11.1.0 to 13.0.0 in #10047 by @akshaysasidrn

[akshaysasidrn]

/review

[akshaysasidrn]

Code Review Agent Run #37201c

• AI Based Review: ✔️ Successful

Code Review Overview

• Summary: The changes primarily focus on updating dependencies and enhancing the Appwrite plugin. Key updates include improved error handling, the introduction of new query operations, and performance optimizations by avoiding sequential execution of asynchronous operations.
• Files: 8
• Issue found: Total - 4, High importance - 4      See detailed feedback ->
• Code change type: Refactoring, Performance Improvement, Dependency Updates
• Unit tests added: False
• Estimated effort to review (1-5, lower is better): 2

High-level Feedback

Ensure proper handling of asynchronous operations to avoid performance bottlenecks and unhandled promise rejections. Implement error handling for JSON parsing to prevent unhandled exceptions. Regularly update dependencies to maintain compatibility and performance.

Detailed Feedback

📄 plugins/packages/appwrite/lib/operations.ts

Issues: Total- 3, High importance- 3

Line 139-139	🔴 High importance - 1
Line 148-148	🔴 High importance - 1
Line 161-161	🔴 High importance - 1

📄 plugins/packages/appwrite/lib/index.ts

Issues: Total- 1, High importance- 1

Line 13-13

🔴 High importance - 1

AI Code Review powered by

[akshaysasidrn]

Bito Code Review Agent Run #37201c - 06/11/2024, 07:45 pm

🔴 High importance

Issue: The 'await' keyword is used inside a return statement. This can lead to unhandled promise rejections if the promise is rejected.

Fix: Store the result of the 'await' call in a variable and then return the variable.

Code suggestion

 @@ -147,7 +147,8 @@
  ): Promise<object> {
 -  await db.deleteDocument(databaseId, collectionId, documentId);
 +  const deleteResult = await db.deleteDocument(databaseId, collectionId, documentId);
 +  return { deleted: true, result: deleteResult };
  }

[github-actions]

Deployment: https://tooljet-pr-10047.onrender.com
Dashboard: https://dashboard.render.com/web/srv-cpl82j7109ks73dnmpmg