fix: set exposedVariables.value to "" for TextArea components fixes Issue: #2454
#2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sherfin94
requested changes
Mar 10, 2022
There was a problem hiding this comment.
Hey @KaviiSuri , your change unfortunately does not resolve the issue. When a TextArea is dragged in, it still is empty instead of showing the default value.
My suggestion is to change the default value of the exposed variable value to 'ToolJet is an open-source low-code platform for building and deploying internal tools with minimal engineering efforts 🚀' instead of ""
|
Hey @sherfin94 , thanks for the correction, |
|
@KaviiSuri please revert the changes to package and package lock files. |
Navaneeth-pk
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2454 by settings the exposedVariables.value for TextArea to an empty string.