Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph accordian moved in options #3305

Merged
merged 6 commits into from
Aug 3, 2022

Conversation

hrutik7
Copy link
Contributor

@hrutik7 hrutik7 commented Jun 17, 2022

In the chart widget, group "show axes" , "show grid lines" and "loading state" inside one accordion named as "options"

image

fixes: #3261

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2022

CLA assistant check
All committers have signed the CLA.

@gondar00
Copy link
Contributor

Hi @hrutik7, can you only commit frontend/src/Editor/Inspector/Components/Chart.jsx and remove all the changes in other files, the changes you have made in Chart.jsx should suffice.

@gondar00 gondar00 added run-ci CI is run only when this label is added create-review-app labels Jun 17, 2022
@hrutik7
Copy link
Contributor Author

hrutik7 commented Jun 17, 2022

sure

Comment on lines 240 to 241


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
@hrutik7 can you please remove these spaces on line num 240 & 241,

@hrutik7
Copy link
Contributor Author

hrutik7 commented Jun 20, 2022

Sure thing

@hrutik7
Copy link
Contributor Author

hrutik7 commented Jun 21, 2022

hey @gondar00 ,
I am not getting why one of the test is failing , I am new to opensource will you please look into this once the things get more clear to me I'll do more contributions
Thanks :)

@gondar00
Copy link
Contributor

Hi @hrutik7, could you once try running the command npm run --prefix frontend lint

@withshubh
Copy link
Contributor

Hey @hrutik7
Please make the required changes so that we can merge this fix?

@hrutik7
Copy link
Contributor Author

hrutik7 commented Jul 6, 2022

Hey @withshubh
issue has been resolved , but I am getting this kind of errors

image

@withshubh
Copy link
Contributor

@gondar00 Need your help here.

@gondar00
Copy link
Contributor

gondar00 commented Jul 7, 2022

@hrutik7 can u try running docker-compose exec server npm i

@withshubh
Copy link
Contributor

@hrutik7 - Did you try running the command suggested above?

@hrutik7
Copy link
Contributor Author

hrutik7 commented Jul 14, 2022

@withshubh yes but still getting the same problem
image

Copy link
Collaborator

@arpitnath arpitnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert back changes added to plugins lock file and packages/woocommerce/lib/operations.json

@shivangT
Copy link
Contributor

Hello @hrutik7 ,
Any updates on the following?
Please revert the changes in the mentioned file. We've to close the issue associated with this.

Thanks

@Navaneeth-pk Navaneeth-pk merged commit b935fd1 into ToolJet:develop Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-review-app run-ci CI is run only when this label is added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "show grid lines", "show axes", "loading state" under one accordion
8 participants