Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixed : Folder icon is now clearly visible in darkmode/issue_3647 #3674

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Bug Fixed : Folder icon is now clearly visible in darkmode/issue_3647 #3674

merged 3 commits into from
Jul 28, 2022

Conversation

UtkarshDixit-py
Copy link
Contributor

Made folder icon's color 2 shades darker so it's clearly visible in dark mode.

Copy link
Collaborator

@kavinvenkatachalam kavinvenkatachalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @UtkarshDixit-py,

Thanks for the PR. Still, the icon is not clearly visible in the dark mode.

image

Here is my suggestion,

In the Folders.jsx file, check if it is a dark mode and add an additional class

<img
src="/assets/images/icons/folder.svg"
alt=""
width="14"
height="14"
className={`folder-ico ${darkMode && 'dark'}`}
/>

Add the class in the theme.scss file under folder-list class

.folder-ico.dark {
  filter: invert(1);
}

cc: @ajith-k-v

@UtkarshDixit-py
Copy link
Contributor Author

@kavinvenkatachalam Sure

@UtkarshDixit-py
Copy link
Contributor Author

UtkarshDixit-py commented Jul 27, 2022

Hey @kavinvenkatachalam I've done what you suggested and it works. Now should i undo the previous commit(change the colour back to the previous lighter shade)?

@ajith-k-v

image

@kavinvenkatachalam
Copy link
Collaborator

Hey @kavinvenkatachalam I've done what you suggested and it works. Now should i undo the previous commit(change the colour back to the previous lighter shade)?

@ajith-k-v

@UtkarshDixit-py The icon color change which you did looks brighter than the existing one. So, you can keep the same color. No need to revert the commit.

@kavinvenkatachalam
Copy link
Collaborator

Hey @UtkarshDixit-py Changes look good! can you resolve the conflicts?

@Navaneeth-pk Navaneeth-pk added the run-ci CI is run only when this label is added label Jul 28, 2022
@Navaneeth-pk Navaneeth-pk merged commit 176f539 into ToolJet:develop Jul 28, 2022
@UtkarshDixit-py UtkarshDixit-py deleted the bug/folder-icon-visibility branch July 28, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-ci CI is run only when this label is added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants