-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fixed : Folder icon is now clearly visible in darkmode/issue_3647 #3674
Bug Fixed : Folder icon is now clearly visible in darkmode/issue_3647 #3674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @UtkarshDixit-py,
Thanks for the PR. Still, the icon is not clearly visible in the dark mode.
Here is my suggestion,
In the Folders.jsx
file, check if it is a dark mode and add an additional class
<img
src="/assets/images/icons/folder.svg"
alt=""
width="14"
height="14"
className={`folder-ico ${darkMode && 'dark'}`}
/>
Add the class in the theme.scss
file under folder-list
class
.folder-ico.dark {
filter: invert(1);
}
cc: @ajith-k-v
@kavinvenkatachalam Sure |
Hey @kavinvenkatachalam I've done what you suggested and it works. Now should i undo the previous commit(change the colour back to the previous lighter shade)? |
@UtkarshDixit-py The icon color change which you did looks brighter than the existing one. So, you can keep the same color. No need to revert the commit. |
Hey @UtkarshDixit-py Changes look good! can you resolve the conflicts? |
Made folder icon's color 2 shades darker so it's clearly visible in dark mode.