Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] Table : adds number as a cell type #4135

Merged
merged 2 commits into from Oct 7, 2022

Conversation

arpitnath
Copy link
Collaborator

Resolves #4079

@arpitnath arpitnath added enhancement New feature or request run-ci CI is run only when this label is added table labels Sep 28, 2022
@shubh22
Copy link
Collaborator

shubh22 commented Sep 28, 2022

Copy link
Collaborator

@kavinvenkatachalam kavinvenkatachalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arpitnath I can see in the code that if I toggle on the editable, seems like we're doing some validation for minValue and maxValue. But, I don't see the fields in the UI. Could you please take a look?

image

@tooljet-bot tooljet-bot temporarily deployed to toojet-pr-4135 October 3, 2022 09:00 Inactive
@tooljet-bot tooljet-bot temporarily deployed to toojet-pr-4135 October 4, 2022 08:39 Inactive
@kavinvenkatachalam kavinvenkatachalam merged commit 6b655b7 into develop Oct 7, 2022
@kavinvenkatachalam kavinvenkatachalam deleted the improvements/table-celltype-number branch October 7, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs documentation run-ci CI is run only when this label is added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Number as a cell type for Tables widgets
5 participants