Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed extra border from black ghost button #8782

Merged
merged 4 commits into from Apr 19, 2024

Conversation

johnsoncherian
Copy link
Collaborator

@johnsoncherian johnsoncherian commented Feb 14, 2024

Removed an extra border which was added on hover to Black Ghost App button. This was causing the button to shift on hover since additional width & height was added

Copy link
Collaborator

@kavinvenkatachalam kavinvenkatachalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnsoncherian Can we remove it instead of commenting it?

frontend/src/_ui/AppButton/AppButton.scss Outdated Show resolved Hide resolved
frontend/src/_ui/AppButton/AppButton.scss Outdated Show resolved Hide resolved
@kavinvenkatachalam kavinvenkatachalam changed the title fix: removed extra border from black ghost button fix: Removed extra border from black ghost button Feb 19, 2024
Copy link

github-actions bot commented Mar 5, 2024

@johnsoncherian johnsoncherian merged commit 7be6a26 into appbuilder-1.6 Apr 19, 2024
7 checks passed
@johnsoncherian johnsoncherian deleted the fix/remove-ghostbutton-border branch April 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants