Login/SSO revamp #8864
Merged
Login/SSO revamp #8864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add workspace login * SSO revamp * small fix * update * remove comments from style file * states for sso buttons * updates * Cancel should close the modal * inherit default sso * small fixes
Closed
gsmithun4
changed the base branch from
release/platformv14
to
release/platformv14-sso-revamp
adishM98
approved these changes
Feb 26, 2024
gsmithun4
added a commit
that referenced
this pull request
Feb 26, 2024
* Login/SSO revamp (#8689) * add workspace login * SSO revamp * small fix * update * remove comments from style file * states for sso buttons * updates * Cancel should close the modal * inherit default sso * small fixes * Add a confirmation modal while enabling workspace level SSO (#8881) * font size update for title * updates- add overlay css * state updates * updates * updates * fixes * update casing * update casing * fixes * drak mode fixes * dark mode fixes * small fix * css update * fix lint errors * redirect url dark theme color fix * remove console log * remove unused editicon --------- Co-authored-by: Anantshree Chandola <anantshreechandola23@gmail.com>
shah21
reviewed
Feb 27, 2024
|
|
||
| const handleHostNameChange = (newHostName) => { | ||
| setHostName(newHostName); | ||
| const changesMade = newHostName !== settings?.configs?.host_name; |
There was a problem hiding this comment.
can you please remove this changedMade variables inside function scopes if we don't need it anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8861