TJ-9611 Added more translation #9770
Open
+5,892
−5,436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
karan-rathod-316
requested review from
johnsoncherian and
prajval-tooljet
and removed request for
johnsoncherian
|
@AkshayKathiriya can you please resolve the merge conflicts? |
|
Hey @PriteshKiri , resolved the merge conflicts. |
|
Thanks @KathiriyaAkshay |
| disabled={isLoading} | ||
| > | ||
| Cancel | ||
| <ButtonSolid variant="tertiary" onClick={closeModal} data-cy="cancel-button" className="modal-footer-divider"> |
There was a problem hiding this comment.
Any specific reason for removing disabled attribute from this button? If not we need to add it back
| @@ -163,7 +161,6 @@ export function AppModal({ | |||
| style={{ | |||
| borderColor: errorText ? '#DB4324 !important' : 'initial', | |||
| }} | |||
There was a problem hiding this comment.
Any specific reason for removing disabled attribute from this button? If not we need to add it back
There was a problem hiding this comment.
@KathiriyaAkshay thanks for the contribution. Can you check the comments added and revert?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TJ-9611 Added more translation