Fix: Remove null values from the foreign key drop-down list #9895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…foreign key drop down
|
Deployment: https://tooljet-pr-9895.onrender.com |
frontend/src/Editor/QueryManager/QueryEditors/TooljetDatabase/SelectBox.jsx
Outdated
Show resolved
Hide resolved
akshaysasidrn
approved these changes
May 28, 2024
…n will not list empty column names
|
Deployment: https://tooljet-pr-9895.onrender.com |
akshaysasidrn
merged commit 48471a2
into
feature/infinitescroll-for-foreignkeydata-tjdb
99 checks passed
akshaysasidrn
added a commit
that referenced
this pull request
Jun 4, 2024
…oolJet database. (#9785) * feat: Added a support for infinite scroll on searching foreign key data * feat: added debounce for search in infinite scroll and refactored the infinite scroll logic on listing Foreign key data * fix: while searching foriegn key values in the drop down of tooljet database for varchar datatype possible search results will be returned and for other datatype strict matching is followed * fix: review comments for optional chaining has been fixed * fix: typo error has been fixed * fix: client search on foreign key drop down is disabled * stylefix: menu height is fixed now for foreign key drop down * fix: foreign key drop down scroll bar moves to top on each render fixed * Fix : Caching the foreign key column options (#9828) * Draft : Caching the fk options * Refactored the code and use promise.all * Used Promise.allSettled to ensure that all promises are processed regardless of whether they resolve or reject. * Changed currentColumn to foreignKey * Removed console * Updated default value of cachedOptions state to empty object * Updated the code with suggestion to uplift check condition * Change the emptyError copyright to No values found * Bug fixed : on mount api request failing * Refactored code from calculations to data by removing optional chaning * Fix: Remove null values from the foreign key drop-down list (#9895) * fix: filtered out null values and brought empty string to top in the foreign key drop down * fix: review comments addressed * fix: while creating or editing FK relation the source column drop down will not list empty column names * stylefix: cell was not clickable on empty string * fix: empty values are not listed on Foreign key drop down used for cell edit * fix: empty string can be added as default in create table operation * Fixed : Fk options are not cached when source column name is updated --------- Co-authored-by: Akshay <akshaysasidharan93@gmail.com> Co-authored-by: Manish Kushare <37823141+manishkushare@users.noreply.github.com> Co-authored-by: manishkushare <kushare.manish9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The Foreign key drop-down should not include null values.
Solution:
If there are any null values, remove them and if there is an empty string, put it at the top of the foreign key drop down list.