Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New powershell connector (PSv2) #14

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Conversation

rhouthuijzen
Copy link
Contributor

tested at custommer environment
Readme is based on the new template
The connector is not based on the new template

@rschouten97
Copy link
Collaborator

@rhouthuijzen the code appears to be well-structured. However, since we are focusing on the PS v2 template, please ensure that the code aligns with the template standards.
I recommend waiting at least a week before making any significant changes, as the template is still undergoing revisions following its recent release.
Furthermore, I recommend merging this pull request only once we have actually implemented this connector.

@Rick-Jongbloed

This comment was marked as resolved.

@Rick-Jongbloed
Copy link
Member

Please make sure insite can be set and unset at resp enable & disable

The following code should be added

    if ($account.PSObject.Properties.Name -Contains 'InSi') {
        $updateAccountFields += "InSi"
    }

@rhouthuijzen rhouthuijzen linked an issue Mar 26, 2024 that may be closed by this pull request
@rhouthuijzen

This comment was marked as resolved.

@rhouthuijzen
Copy link
Contributor Author

Please make sure insite can be set and unset at resp enable & disable

The following code should be added

    if ($account.PSObject.Properties.Name -Contains 'InSi') {
        $updateAccountFields += "InSi"
    }

Before we add this. We should also make the $previousAccount list dynamic. This needs to be tested first.

@rhouthuijzen rhouthuijzen linked an issue Jun 10, 2024 that may be closed by this pull request
Copy link

@JeroenBL JeroenBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what I've seen in the changed/added code, everything is OK. So ready to merge.

@rhouthuijzen rhouthuijzen merged commit d237c1a into master Jun 21, 2024
@rhouthuijzen rhouthuijzen deleted the new-powershell-connector branch June 21, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants