Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New powershell connector (PSv2) #11

Merged
merged 18 commits into from
Apr 10, 2024
Merged

Conversation

rhouthuijzen
Copy link
Contributor

fieldMapping added.
tested at custommer
Readme and Scripts are based on the new template

@rhouthuijzen rhouthuijzen linked an issue Feb 14, 2024 that may be closed by this pull request
@rschouten97
Copy link
Contributor

@rhouthuijzen the code appears to be well-structured. However, since we are focusing on the PS v2 template, please ensure that the code aligns with the template standards.
I recommend waiting at least a week before making any significant changes, as the template is still undergoing revisions following its recent release.
Furthermore, I recommend merging this pull request only once we have actually implemented this connector.

@rhouthuijzen rhouthuijzen linked an issue Feb 28, 2024 that may be closed by this pull request
Copy link
Member

@Rick-Jongbloed Rick-Jongbloed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a large update so it's hard to really check line by line, but since it's already tested and it looks good, i'll approve this pr

@Rick-Jongbloed Rick-Jongbloed merged commit fbeb8a1 into main Apr 10, 2024
@Rick-Jongbloed Rick-Jongbloed deleted the new-powershell-connector branch April 10, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add succes when 404 not found occurs. You cannot call a method on a null-valued expression. on correlate
3 participants