Rename unfortunately named variables to be more inclusive. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per suggestions made on a similar PR, I have renamed the variable to "luredPos" as it seems to be a more accurate description of what the variable does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "MovieLure.py", under code that handles creating sequences for dollar-bill lures, there are TTO-era variables named "retardPos" and "retardHpr". As you can probably figure out, these don't really feel appropriate to keep in this day and age.
This PR changes these variables to "simulatedPos" and "simulatedHpr" respectively.
As these are simple renames, they don't have any function differences between each other, but just in cause, I have tested and verify that the changes work identically to it's unrenamed counterpart.