removeAccountsFromAList -> removeAccountsFromList #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consistent with addAccountsToList and RemoveAccountsFromListParams https://github.com/TootSDK/TootSDK/discussions/138
davidgarywood
requested changes
Apr 1, 2023
Co-authored-by: David W <davidw@roboheadz.com>
|
I think it can be merged, if the linter is happy 😄 |
|
Swiftint is complaining about this line TootClient+Account.swift:114:26: warning: Blanket Disable Command Violation: The disabled 'todo' rule should be re-enabled before the end of the file (blanket_disable_command) |
|
I'm going to approve this, and then fix the linter with a separate PR shortly |
davidgarywood
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consistent with addAccountsToList and RemoveAccountsFromListParams
https://github.com/TootSDK/TootSDK/discussions/138