API to get, follow and unfollow tags #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkostov
reviewed
Apr 22, 2023
| /// - Parameter id: Name of the tag. | ||
| @discardableResult | ||
| func followTag(_ id: String) async throws -> Tag { | ||
| let req = HTTPRequestBuilder { |
There was a problem hiding this comment.
This method is supported only by Mastodon and Friendica, we need a guard for the flavour.
kkostov
reviewed
Apr 22, 2023
| @discardableResult | ||
| func unfollowTag(_ id: String) async throws -> Tag { | ||
| let req = HTTPRequestBuilder { | ||
| $0.url = getURL(["api", "v1", "tags", id, "unfollow"]) |
There was a problem hiding this comment.
Same here, only masto and Friendica
|
@Tunous Looks great! If you could you add a guard for the flavour of the follow/unfollow methods then it will be ready to merge 🚀. Thanks a lot! 🙌 |
|
@kkostov Good find. This also gives me an idea that I should hide that function from the app UI. I added a property to tell if the feature is supported to be able to do that. |
kkostov
approved these changes
Apr 22, 2023
There was a problem hiding this comment.
@Tunous Nice! I like the availability flag a lot! (@davidgarywood)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.