Dialogs and tweaks

[fllp]

Converts QML pages for adding and editing (Add.qml, Edit.qml) vocabulary into Silica Dialogs (no buttons, please 😉 ).

Also adds some fine tuning:

• set focus on first entry field (word) when adding vocabulary
• enable enter key only after text was input
• move cursor to end of first text field (word) when editing
• anchor contents to individual parent instead of page

New add dialog:

Acceptable after input:

---

Edit dialog:

[Top-Ranger]

Thanks a lot! I'll look into it and test it.

There were two reasons why I used a button in the original design:

1. It made Error handling easier. I could abort the whole procedure and show an error message in case something went wrong. I have to check how this works with Silica Dialogs.
2. In earlier versions saving was sometimes a bit slow. By using a button, the feedback to the user was a better (no stuck half-changed page). I don't think that's still a problem.

For me it is important that 1. still holds true (that is, in case of any error the page is still open and thus the input is not lost). Have you tested that case?

[fllp]

I see...I wasn't aware of that. In fact this started as a simple hack using Patchmanager to change the QML files. And that is also the only testing I did: Applying the patch to see if it works. My knowledge of QML and QTQuick is very rudimentary - basically what die documentation says about dialogs. Other than looking for the pop command I did not examine the functions further. There are some bools that allow checking the transient state of the Dialog when closing but to me it's unclear if that might with help error handling. https://sailfishos.org/develop/docs/silica/qml-sailfishsilica-sailfish-silica-dialog.html/#acceptPending-prop

[Top-Ranger]

I've run some tests, and unfortunately I couldn't get the page to stop closing if an error occured (to test this, simply add "return false;" before this line). Because of that, I'll not merge this branch.

If anyone has an idea how to fix it, I'll be happy to merge the changes.

Thanks again for the suggestion.

[fllp]

That's a pity. Well, thanks for trying. I'm sorry that I can't be of any help with the error catching. Maybe in the future something comes up. I'll continue to use the homebrew patch ;)