Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aiohttp constraints #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

No767
Copy link

@No767 No767 commented Oct 23, 2023

With aiohttp releasing 3.9.0, which supports 3.12, we need to update the current constraints

Fixes #

Proposed Changes

With aiohttp releasing 3.9.0, which supports 3.12, we need to update the current constraints
@No767
Copy link
Author

No767 commented Oct 24, 2023

ping @Esmeray6

@Esmeray6
Copy link
Contributor

ping @Esmeray6

Ping someone from the top.gg team (if someone actually cares to look into these 🙃).

I don't maintain the library anymore. Or did you just want a second pair of eyes?

@No767
Copy link
Author

No767 commented Oct 24, 2023

ping @Esmeray6

Ping someone from the top.gg team (if someone actually cares to look into these 🙃).

I don't maintain the library anymore. Or did you just want a second pair of eyes?

I'll take care of maintaining the library if you want me to do so. I'll contact the topgg team if they are able to merge this pr

@Esmeray6
Copy link
Contributor

If nothing has changed by now, you'll have to run your changes through someone from the team (no collaborator permissions, you just create PRs and the team merges them).

My wonder is whether anyone from the team will bother with this library after... 3? years of no updates to this repo.

With this said, it's entirely up to you.

@No767
Copy link
Author

No767 commented Oct 25, 2023

If nothing has changed by now, you'll have to run your changes through someone from the team (no collaborator permissions, you just create PRs and the team merges them).

True, but this PR doesn't really have any changes. The updated requirements for aiohttp follow the same exact requirements as discord.py's aiohttp version requirements. I'll try and ask someone on the team if I can help out

@Esmeray6
Copy link
Contributor

It's more about the fact that maintainers, as far as I recall (3 years ago, give or take), don't have write access to the repositories. So, they're simply stuck with waiting for whoever to review the changes and accept the PRs. Correct me if that's changed at any point after that.

Nevertheless, I'm just ranting off-topic at this point. My apologies.

@Esmeray6
Copy link
Contributor

@No767 Additionally if you still want to maintain this library, I would prefer to be contacted by someone from the staff to transfer ownership of the PyPi package.

@No767
Copy link
Author

No767 commented Jan 20, 2024

@Esmeray6 Sure

@Esmeray6
Copy link
Contributor

Esmeray6 commented Mar 4, 2024

Any update on this?

@Esmeray6
Copy link
Contributor

This PR is overwritten by #74, can be closed if that gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants