Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown argument "words" for filter "hacksaw(unit, limit, allowed_tags, append) #2

Closed
michaelrog opened this issue Apr 10, 2018 · 2 comments

Comments

@michaelrog
Copy link
Member

Originally posted by @shantamg:


I had been using the hacksaw plugin with Craft 2 and was doing this:

hacksaw(words='30')

After upgrading to Craft 3 and installing Wordsmith, Craft raises raises an unknown argument error.
It's an easy fix, just need to change it to

hacksaw(unit='words', limit='30')

but I thought I'd mention it because this a case where Wordsmith is not backwards compatible with hacksaw.

@michaelrog
Copy link
Member Author

Thanks for catching this! We should definitely add some param normalization there for backwards compatibility.

@shantamg
Copy link

Well, one thing I just realized when trying to help solve the issue is that the version of Hacksaw that I am using is 1.1.2, which I just realized is a different repo from the latest version of hacksaw.

That's pretty confusing because I never got a notice in the craft updates so I was unaware.

From what I can tell, Hacksaw 2.x syntax changed to be more like what is supported here so perhaps this is moot.

I would just say that others in my situation (installed craft_hacksaw before it stopped being maintained) may not know there is a new version.

Perhaps @ryanshrum is interested in this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants