Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSDK-645 Document [Update] Wallet State #162

Merged
merged 5 commits into from
Nov 29, 2023
Merged

TSDK-645 Document [Update] Wallet State #162

merged 5 commits into from
Nov 29, 2023

Conversation

DiademShoukralla
Copy link
Collaborator

@DiademShoukralla DiademShoukralla commented Nov 27, 2023 •
edited
Loading

Purpose

Document Update Wallet State & tie-in wallet state with the rest of the Reference Documentation

Approach

  • minor updates to existing code examples to include line-highlighting. Since the code examples contain all necessary needed to run, the specific line that is being demonstrated is highlighted.
  • Added example + documentation for update wallet state under "Service Kit > Usage"
  • Under "Reference > Wallet State" added information for initializing and updating wallet state. This links to the sections under "Service Kit".
  • Added a blurb under "Reference > Build Lock" to indicate that they should update wallet state

Testing

Ensured all examples worked locally

Tickets

  • closes TSDK-645

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023 •
edited
Loading

Test Results

201 tests  ±0   201 ✔️ ±0   23s ⏱️ ±0s
  18 suites ±0       0 💤 ±0 
  18 files   ±0       0 ❌ ±0 

Results for commit 251de4b. ± Comparison against base commit 9fc5def.

♻️ This comment has been updated with latest results.

@DiademShoukralla DiademShoukralla self-assigned this Nov 28, 2023
@DiademShoukralla DiademShoukralla changed the title TSDK-645 [[WIP]] TSDK-645 Document [Update] Wallet State Nov 28, 2023
@DiademShoukralla DiademShoukralla marked this pull request as ready for review November 28, 2023 23:17
mundacho
mundacho approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@mundacho mundacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor comments but the rest looks good to me.

documentation/docs/reference/wallet-state.mdx Outdated Show resolved Hide resolved
documentation/docs/reference/wallet-state.mdx Show resolved Hide resolved
documentation/docs/reference/wallet-state.mdx Outdated Show resolved Hide resolved
@DiademShoukralla DiademShoukralla merged commit 47893ff into main Nov 29, 2023
4 checks passed
@DiademShoukralla DiademShoukralla deleted the TSDK-645 branch November 29, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mundacho mundacho mundacho approved these changes

Assignees

@DiademShoukralla DiademShoukralla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DiademShoukralla @mundacho