Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BN-1138/113434 group and series asset token #78

Merged
merged 23 commits into from
Aug 29, 2023
Merged

Conversation

nandotorterolo
Copy link
Contributor

@nandotorterolo nandotorterolo commented Aug 1, 2023

Purpose

TAMv2 Assets
A TAMv2 asset is a token that has the following attributes:

  • A group identifier
  • A series identifier
  • A quantity

Asset Lifecycle

  • Mint a group constructor token
  • Mint a series constructor token (this can be done in the same transaction as the group constructor is minted)
  • Mint an asset token using the group and series constructor token just minted.

Note

This PR is linked to the following PRs, and only group constructor token, with empty series was implemented.

Approach https://github.com/Topl/tips/tree/main/TIP-0003

  • Implement models step1: group constructor token
  • Implement models step1: series constructor token

Testing

protobuf complie

Tickets

step 1: https://topl.atlassian.net/browse/BN-909

@nandotorterolo nandotorterolo changed the title Bn group asset token BN-1138/113434 group and series asset token Aug 15, 2023
Copy link
Collaborator

@mundacho mundacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is only for group Ids, but I am not sure if I'm getting the scope right. However, what is missing is the modification of the IO Transaction to support a list of group policies.

proto/brambl/models/box/value.proto Show resolved Hide resolved
Copy link
Collaborator

@DiademShoukralla DiademShoukralla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I did have some questions/callouts for which I left comments on

proto/brambl/models/box/asset.proto Show resolved Hide resolved
proto/brambl/models/box/value.proto Outdated Show resolved Hide resolved
proto/brambl/models/box/value.proto Outdated Show resolved Hide resolved
proto/brambl/models/box/value.proto Show resolved Hide resolved
proto/brambl/models/event.proto Show resolved Hide resolved
@nandotorterolo nandotorterolo merged commit 597f46f into main Aug 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants