Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAM_V2_assetsStatements #86

Merged
merged 3 commits into from
Sep 11, 2023
Merged

TAM_V2_assetsStatements #86

merged 3 commits into from
Sep 11, 2023

Conversation

nandotorterolo
Copy link
Contributor

Purpose

Required for:

  • Asset Minting Statement
  • Asset Merging Statement
  • Asset Splitting Statement

Copy link
Collaborator

@DiademShoukralla DiademShoukralla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left a few questions + minor field rename

proto/brambl/models/box/assets_statements.proto Outdated Show resolved Hide resolved
proto/brambl/models/box/assets_statements.proto Outdated Show resolved Hide resolved
proto/brambl/models/box/value.proto Show resolved Hide resolved
proto/brambl/models/box/value.proto Outdated Show resolved Hide resolved
@nandotorterolo
Copy link
Contributor Author

@SeanCheatham Before release, I want to confirm with you this assumtion. Assets were never involved in any Topl-product, so all changes in protobuf-specs Value.Asset could safely changed.

@SeanCheatham
Copy link
Collaborator

@SeanCheatham Before release, I want to confirm with you this assumtion. Assets were never involved in any Topl-product, so all changes in protobuf-specs Value.Asset could safely changed.

@nandotorterolo You can modify Value.Asset. It may break some places in the code, but from a feature-standpoint, the original Value.Asset corresponds to Dion assets which we don't really need with TAMv2.

@nandotorterolo nandotorterolo merged commit 6ef6c3f into main Sep 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants