Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ratio #92

Merged
merged 1 commit into from
Oct 16, 2023
Merged

refactor ratio #92

merged 1 commit into from
Oct 16, 2023

Conversation

nandotorterolo
Copy link
Contributor

Purpose

Question; is there a reason why this https://github.com/Topl/protobuf-specs/blob/main/proto/node/models/ratio.proto pb spec was added to the node package?
I ask because I was looking at the definition of UpdateProposal, and I think it may introduce a circular dependency across packages (node depends on brambl, brambl depends on node). But maybe I am missing something and it was intentional and not an issue

Approach

  • moved to quivr shared.

Note

  • scala-Protobuf compiler does not show any warning or error about circular dependency, which I am not sure If it is really a circular dependency.
  • In case we procced with this refactor we will need to update the Node.
  • any other suggested place to move it?

Tickets

BN-1248

Copy link
Collaborator

@SeanCheatham SeanCheatham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to make this change since a Ratio might be a useful primitive in Quivr at some point anyway. Technically I don't think there are circular dependency issues with it right now, but if you think there might be in the future, it's better to move it sooner than later.

@nandotorterolo nandotorterolo merged commit 8e084d4 into main Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants