Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Question; is there a reason why this https://github.com/Topl/protobuf-specs/blob/main/proto/node/models/ratio.proto pb spec was added to the node package?
I ask because I was looking at the definition of UpdateProposal, and I think it may introduce a circular dependency across packages (node depends on brambl, brambl depends on node). But maybe I am missing something and it was intentional and not an issue
Approach
Note
Tickets
BN-1248