Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSDK-789 BTC Monitoring #10

Merged
merged 25 commits into from
May 7, 2024
Merged

TSDK-789 BTC Monitoring #10

merged 25 commits into from
May 7, 2024

Conversation

mundacho
Copy link
Collaborator

@mundacho mundacho commented May 6, 2024

Purpose

The goal of this PR is to implement monitoring of the BTC network into the bridge.

Approach

  • A new architecture was implemented using a state machine and streams to keep the state of the system in sync with the sessions.
  • /api/confirm-deposit-btc WS was removed.
  • Added new parameters for the launcher: --btc-url, --btc-port, --btc-user, --btc-password, --zmq-url, --zmq-port.
  • Added support for configuring these parameters using environment variables (for docker deploys)
  • Modified test to rely on monitoring.

Testing

  • The unit tests were updated
  • The integration test was updated
  • Further testing is required for UI, will be done in another ticket.

Tickets

  • TSDK-789

Copy link
Contributor

github-actions bot commented May 6, 2024

Test Results

14 tests   - 1   14 ✅  - 1   33s ⏱️ -1s
 5 suites  - 1    0 💤 ±0 
 5 files    - 1    0 ❌ ±0 

Results for commit 8352d10. ± Comparison against base commit 30c95b7.

This pull request removes 1 test.
co.topl.bridge.controllers.ConfirmDepositControllerSpec ‑ ConfirmDepositController should succeed on valid input

♻️ This comment has been updated with latest results.

@mundacho mundacho marked this pull request as ready for review May 6, 2024 15:02
Copy link
Collaborator

@DiademShoukralla DiademShoukralla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docker/README.md Outdated Show resolved Hide resolved
mundacho and others added 2 commits May 7, 2024 11:37
Co-authored-by: Diadem <d.shoukralla@topl.me>
@mundacho mundacho merged commit cbc2dc2 into main May 7, 2024
6 checks passed
@mundacho mundacho deleted the tsdk-789-btc-monitoring branch May 7, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants