-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSDK-789 BTC Monitoring #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc4d9a2.
Test Results14 tests - 1 14 ✅ - 1 33s ⏱️ -1s Results for commit 8352d10. ± Comparison against base commit 30c95b7. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
DiademShoukralla
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
integration/src/test/scala/co/topl/bridge/BridgeIntegrationSpec.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Diadem <d.shoukralla@topl.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The goal of this PR is to implement monitoring of the BTC network into the bridge.
Approach
/api/confirm-deposit-btc
WS was removed.--btc-url
,--btc-port
,--btc-user
,--btc-password
,--zmq-url
,--zmq-port
.Testing
Tickets