TSDK-744 Confirm deposit (p. 2) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiademShoukralla
approved these changes
Feb 22, 2024
topl-btc-bridge/src/main/scala/co/topl/bridge/controllers/ConfirmDepositController.scala
Outdated
Show resolved
Hide resolved
topl-btc-bridge/src/main/scala/co/topl/bridge/controllers/ConfirmDepositController.scala
Outdated
Show resolved
Hide resolved
…irmDepositController.scala Co-authored-by: Diadem <diademrocks@gmail.com>
…irmDepositController.scala Co-authored-by: Diadem <diademrocks@gmail.com>
Test Results1 tests 1 ✅ 23s ⏱️ Results for commit f41ef1a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Goal of this task is to implement the confirm deposit WS. The confirm deposit WS is used (in the current version) to tell the bridge that a deposit has been made and that it can proceed to mint the assets on the Topl chain.
Approach
The WS was implemented and tests were added. We also implemented a sync WS. This WS was implemented to synchronize the wallet (because it was on a docker container). The sync WS was not needed in the end but we are keeping it in the code for the moment because we might need it in the future.
Testing
We implemented unit tests and a big integration test.
Tickets