Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSDK-784 BTC Demo Wallet Integration #8

Merged
merged 1 commit into from
Apr 23, 2024
Merged

TSDK-784 BTC Demo Wallet Integration #8

merged 1 commit into from
Apr 23, 2024

Conversation

DiademShoukralla
Copy link
Collaborator

Purpose

To enable integration with the BTC Demo Wallet app.

Approach

  • Display sessionId once a session is established (to be used in the BTC demo wallet)
  • Once a session is established, poll to see if tBTC has begun minting. If it has, that means BTC was deposited. In this case, display the minting waiting screen
  • Removed button and page that is no longer used

Testing

Manually tested

Tickets

  • TSDK-784

@DiademShoukralla DiademShoukralla self-assigned this Apr 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 12, 2024 •
edited

Test Results

15 tests  ±0   15 ✅ ±0   34s ⏱️ ±0s
 6 suites ±0    0 💤 ±0 
 6 files   ±0    0 ❌ ±0 

Results for commit ac08be3. ± Comparison against base commit c2d99ab.

♻️ This comment has been updated with latest results.

@DiademShoukralla DiademShoukralla marked this pull request as ready for review April 12, 2024 18:49
mundacho
mundacho approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@mundacho mundacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DiademShoukralla DiademShoukralla merged commit 30c95b7 into main Apr 23, 2024
6 checks passed
@DiademShoukralla DiademShoukralla deleted the TSDK-784 branch April 23, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mundacho mundacho mundacho approved these changes

Assignees

@DiademShoukralla DiademShoukralla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DiademShoukralla @mundacho