Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Single Serilog logger #234

Closed
pawelpabich opened this issue May 28, 2015 · 7 comments
Closed

Single Serilog logger #234

pawelpabich opened this issue May 28, 2015 · 7 comments

Comments

@pawelpabich
Copy link
Contributor

Hi,

Serilog docs say there should be only one Serilog logger. At the moment the TopShelf integration with Serilog takes Serilog config as input so I end up with 2 loggers. One in TopShelf and one in my code.

Would it be a good idea to extend UseSerilog with another overload that takes an instance of Serilog Logger instead of Serilog config?
@IanYates
Copy link

👍 - makes sense to me.

@phatboyg
Copy link
Contributor

phatboyg commented Jun 1, 2015

Pull request?

@pawelpabich
Copy link
Contributor Author

Sure, I will have a look

pawelpabich added a commit to pawelpabich/Topshelf that referenced this issue Jun 3, 2015
@pawelpabich
Added ability to pass root level Serilog logger to Topshelf so both T…
7d5bc51 
…opshelf code and app code can share the same logger. Topshelf#234
@pawelpabich pawelpabich mentioned this issue Jun 3, 2015
Closed
@pawelpabich
Copy link
Contributor Author

Anything I should change ?

@joelweiss
Copy link

👍 I'm waiting on this fix as well, any ETA?

@asherw
Copy link

asherw commented Sep 25, 2015

Hi, put me down as another person who would also like this in.
Thanks!

@pawelpabich
Copy link
Contributor Author

Anything else I can do to help with this PR ?

phatboyg pushed a commit that referenced this issue Dec 3, 2015
@pawelpabich @phatboyg
Added ability to pass root level Serilog logger to Topshelf so both T…
e223a6b 
…opshelf code and app code can share the same logger. #234
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added ability to pass root level Serilog logger to Topshelf pawelpabich/Topshelf
5 participants
@phatboyg @pawelpabich @IanYates @joelweiss @asherw