Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Update Serilog to v2; #368

Closed
wants to merge 2 commits into from
Closed

Conversation

jwhitex
Copy link
Contributor

@jwhitex jwhitex commented May 4, 2017

Version Matches MassTransit.SerilogIntegration Serilog version. Resolves #348, #342, and #346.

@jwhitex
Copy link
Contributor Author

jwhitex commented May 4, 2017

@phatboyg We suspect using Serilog v1 in our Topshelf project has something to do with not getting logs when exceptions are thrown in MassTransit consumers. Note that we are setting the global Log.Logger with a Serlog v1 logger and applying the UseSerilog() extension on both the bus and the service 'Configurator'.

@waynebrantley
Copy link

Any chance of getting this closed and a new build published?

@phatboyg
Copy link
Contributor

Yeah, soon for sure.

@ar1k
Copy link

ar1k commented Jun 5, 2017

I think this PR needs in one more change. Because the memory buffer may contain events that have not yet been written to the target sink, it is important to call Log.CloseAndFlush(), and appropriate place is Shutdown() in SerilogLogWriterFactory.cs. Hope PR will be accepted soon after that :)

@phatboyg
Copy link
Contributor

phatboyg commented Jun 5, 2017

Sounds good to me. Will get to this after the vs2017 branch is merged.

@ar1k
Copy link

ar1k commented Aug 8, 2017

@phatboyg, Is there any chance that the request will be accepted soon?

@stefanopretto
Copy link

@phatboyg I second the request, I would really love to be able to use the latest Serilog version with Topshelf.

@stephenpatten
Copy link

@phatboyg is the goal to be backwards compatible, or is this a nuget issue?

@phatboyg
Copy link
Contributor

phatboyg commented Oct 2, 2017

I'll get it merged soon. I need to update Topshelf anyway.

@phatboyg phatboyg closed this Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants