Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MaxMindDatabase.php #172

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Update MaxMindDatabase.php #172

merged 1 commit into from
Mar 9, 2020

Conversation

jalmatari
Copy link
Contributor

@jalmatari jalmatari commented Feb 15, 2020

It's show error in some cases when Working in multi branches, this edit fixes the problem

@Torann Torann merged commit a6f00b8 into Torann:master Mar 9, 2020
@dwightwatson
Copy link
Contributor

This update has broken MaxMindDatabase for me.

[2020-03-09 23:23:40] testing.ERROR: mkdir(): File exists {"exception":"[object] (ErrorException(code: 0): mkdir(): File exists at /Users/Dwight/Sites/my-app/vendor/torann/geoip/src/Services/MaxMindDatabase.php:29)

This is with the default configuration. Out of the box the path is storage/app/geoip.mmdb, your call to str_replace turns this into storage/app and then tries to create that directory, which already exists.

This PR should be reverted, and made again if necessary with a proper explanation of the error that is being seen and relevant tests to ensure it isn't breaking existing functionality.

Torann added a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants