This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
(Binary Serialization Part 1) Updated TorchCraft IDL to include types for frame serialization #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebetica
approved these changes
Nov 17, 2017
jgehring
reviewed
Nov 17, 2017
BWEnv/fbs/messages.fbs
Outdated
| associatedCount:int; // spiderMines, scarabs, interceptors, nuke | ||
| } | ||
|
|
||
| table UnitsByPlayerId { |
There was a problem hiding this comment.
UnitsOfPlayer or PlayerUnits? Likewise below.
BWEnv/fbs/messages.fbs
Outdated
| targetId:int; | ||
| targetX:int; | ||
| targetY:int; | ||
| // Current implementation has equivalence operator that compares vars other than first_frame |
There was a problem hiding this comment.
Might be cleared to say "that ignores first_frame". The same (ignoring frame) is true for UnitCommand.
…e-frame-string (Binary Serialization Part 2) Removing frame_string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#213
I'll be issuing a series of pull requests which cover the full transition to binary serialization.
Adding the FlatBuffer types which will represent frame data.