Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inheriting from CatchableError for the news exceptions because Exception shouldn't be directly inherited from #12

Merged
merged 1 commit into from May 8, 2020

Conversation

onqtam
Copy link
Contributor

@onqtam onqtam commented May 7, 2020

regarding the CatchableError - see here: https://github.com/nim-lang/Nim/blob/v1.2.0/lib/system/exceptions.nim#L52

I also see that there isn't a git tag for the 0.4 version and that might be a problem for nimble.

@Tormund Tormund merged commit 1caa232 into Tormund:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants