Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better security for deploying in heroki #12

Closed
wants to merge 1 commit into from

Conversation

Adventuresofbot
Copy link

Before @Torom already did how to deploy using action but I think it is not fully safe as it leak our mail adress thought that one is fast but still not secure
This one is full secure and no one able to leak or see your mail adress

Before @Torom already did how to deploy using action but I think it is not fully safe as it leak our mail adress thought that one is fast but still not secure 
This one is full secure and no one able to leak or see your mail adress
@Torom
Copy link
Owner

Torom commented May 3, 2022

That was the way I done it before. But it has two major disadvantages:

  • Each user must install the Heroku CLI
  • There are no automatic deploys for changes

I understand that publishing the email address is unwanted. But this is quite simple to prevent. I will change this and then you are welcome to test it.

@Torom
Copy link
Owner

Torom commented May 3, 2022

With 16a86a8 you don't save the email in the main.yml, instead you have to add another secret with your email in your github repository. Please test it and report back.

@Adventuresofbot
Copy link
Author

Then I think with your main we can also private heroku app
And that way we dont have to edit main.yml

@Torom
Copy link
Owner

Torom commented May 3, 2022

Yes that would be possible. But first, the app name is not a secret. And secondly, the user has to push a change anyway to trigger the first deploy. So I don't want to change that.

@Adventuresofbot
Copy link
Author

Yes u r correct

@Torom
Copy link
Owner

Torom commented May 4, 2022

If this solves your problem, you can close the PR and the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants