Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "Intangible"/"ItemList"/... types #15

Open
Toromyx opened this issue Nov 21, 2023 · 2 comments
Open

Handle "Intangible"/"ItemList"/... types #15

Toromyx opened this issue Nov 21, 2023 · 2 comments

Comments

@Toromyx
Copy link
Owner

Toromyx commented Nov 21, 2023

During deserialization of a https://schema.org/Recipe it came to my attention that https://schema.org/recipeInstructions can apparently be "an ordered list with HowToStep and/or HowToSection items", but that fact is nowhere to be seen in the structured data.

One of these things must be true:

  1. The description is wrong. (i doubt it)
  2. The structured data is missing HowToStep and HowToSection as possible types for recipeInstructions. (possible)
  3. ItemList and ListItem are actually generic types. (i fear for the worst)
@Toromyx
Copy link
Owner Author

Toromyx commented Nov 22, 2023

I opened a discussion: schemaorg/schemaorg#3411

@Toromyx
Copy link
Owner Author

Toromyx commented Nov 27, 2023

schemaorg/schemaorg#3411 (comment)

By current schema.org semantics, the typing of the objects in the ItemList can be anything like an old school Java List. But in practice, they are going to be the things in the range of the property they are used in [...].

This suggests to me that the types of this library need to be re-thought. The choice of using serde also doesn't seem ideal, maybe built-in https://github.com/timothee-haudebourg/json-ld support makes more sense.

For now I found a workaround but I might revisit this later or if someone else actually wants to use this library :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant