Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.6.4 #59

Merged
merged 2 commits into from
Jan 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .idea/appInsightsSettings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 18 additions & 12 deletions .idea/deploymentTargetDropDown.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions .idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions .idea/migrations.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions FloatingBubbleView/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ plugins {

android {

compileSdk 33
compileSdk 34

defaultConfig {
minSdk 21
targetSdk 33
targetSdk 34

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles "consumer-rules.pro"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,19 @@ open class Bubble(
/**
* - don't call remove if the view did not call show() previously
* - call windowManager.removeViewImmediate() will make the view can't change when added again
* - add this line 'if (root.windowToken == null) return' will prevent the view from being removed in some cases
* */
open fun remove() {
if (root.windowToken == null) return
windowManager.removeView(root)
// if (root.windowToken == null) return
try {
windowManager.removeView(root)

if (containCompose) {
composeOwner!!.onPause()
composeOwner!!.onStop()
composeOwner!!.onDestroy()
}
if (containCompose) {
composeOwner!!.onPause()
composeOwner!!.onStop()
composeOwner!!.onDestroy()
}
}catch (_: Exception){}
}

fun update() {
Expand Down
12 changes: 8 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# 🍀Floating Bubble View
An Android library that adds floating bubbles to your home screen 🎨, supports both XML and 💘 Jetpack Compose
An Android library that creates floating bubbles on top of the screen 🎨, supports both XML and 💘 Jetpack Compose

<br>

<div align="center">

Find this library useful? Don't forget to show some love by giving a `Star⭐` 🥰
<h6> Find this library useful? 🥰 Don't forget to show some love by giving a &nbsp; -Star⭐- </h6>

| Bubble | Custom |
| :-: | :-: |
Expand Down Expand Up @@ -393,6 +393,7 @@ class MyServiceKt : ExpandableBubbleService() {

```java
public class MyService extends ExpandableBubbleService {
...
@Override
public void startNotificationForeground() {
startForeground(...);
Expand All @@ -411,6 +412,8 @@ public class MyService extends ExpandableBubbleService {

```kotlin
class MyService : FloatingBubbleService() {
...
// optional, of course
override fun startNotificationForeground() {
startForeground(...)

Expand All @@ -431,7 +434,7 @@ Starting in Android 13 (API level 33), notifications are only visible if the "PO

> The service will run normally even if the notification is not visible. 🍀

> P/s: You still need to initialize the notification before showing any view.
> You still need to initialize the notification before showing any view.

</details>

Expand Down Expand Up @@ -470,9 +473,10 @@ Starting in Android 13 (API level 33), notifications are only visible if the "PO
Contributions are welcome! 🙌

- If you come across a bug or have an idea for a new feature, please let us know by creating an [Issue](https://github.com/TorryDo/Floating-Bubble-View/issues) 🐛💡
- If you're interested in taking on an [open issue](https://github.com/TorryDo/Floating-Bubble-View/issues), please comment on it so others are aware 😊
- If you've already fixed a bug or implemented a feature, feel free to submit a [Pull request](https://github.com/TorryDo/Floating-Bubble-View/pulls) 🚀
- Having questions, ideas, or feedback? Don't worry, I gotchu. Simply open a [Discussion](https://github.com/TorryDo/Floating-Bubble-View/discussions) 🔊
- Find this project useful? Don't forget to show some love by giving a star ⭐
- Find this project useful? 🥰 Don't forget to show some love by giving a star ⭐

Thank you! 💖

Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ RELEASE_SIGNING_ENABLED=true

GROUP=io.github.torrydo
POM_ARTIFACT_ID=floating-bubble-view
VERSION_NAME=0.6.3
#prev: 0.6.2
VERSION_NAME=0.6.4
#prev: 0.6.3

POM_NAME=FloatingBubbleView
POM_PACKAGING=aar
Expand Down
Loading